On 2013-07-02, Alan Bateman wrote: > On 01/07/2013 16:32, Erik Helin wrote: > >Hi all, > > > >this change excludes the following two MemoryMXBean tests: > >- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > >- java/lang/management/MemoryMXBean/MemoryTest.java > > > >This is needed since a change in hotspot added a new memory pool for > >metaspace: > > > >>hg log hotspot-main/hotspot: > >> changeset: 4861:71963b3f802a > >> user: ehelin > >> date: Wed Jun 26 16:58:37 2013 > >> summary: 8013590: NPG: Add a memory pool MXBean for Metaspace > >These tests need to be excluded for a (very short) time to be able to > >integrate hotspot-main into jdk8/jdk8. > > > >Webrev: http://cr.openjdk.java.net/~ehelin/8019500/webrev.00/ > > > >Please note that the change is for jdk8/jdk8 (not jdk8/tl) since hotspot > >needs to be integrated into jdk8/jdk8. > > > >I have also sent out a review request for a change that fixes the test > >and removes the tests from ProblemList.txt. This change can be applied > >to jdk8/tl as soon as hotspot has been integrated and pulled down to jdk8/tl. > > > >Thanks, > >Erik > This looks okay to me, although you might want to push-out > "generic-all" so that it's consistent with the other lines.
Thanks! I will make sure to use the correct alignment for "generic-all" before I push. Again, thanks for your quick reply! Erik > -Alan