Hi Brian,
I took a look through the code and I don't see how sdiff ==
Integer.MIN_VALUE is handled.
In any case, as long as the runtimes and memory usage are tractable, the
set of test cases should be augmented to include sdiff ==
Integer.MIN_VALUE and (long)Integer.MIN_VALUE + 1, etc.
Cheers,
-Joe
On 7/24/2013 5:21 PM, Brian Burkhalter wrote:
JDK 8 Reviewers:
This review request concerns the issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378503
for which the proposed webrev is
http://cr.openjdk.java.net/~bpb/6378503/
The fix consists in preventing overflowing the int type in certain places. The
added test case is equivalent to the one described in the issue report insofar
as I can tell but is much less computationally expensive.
Note that this patch follows that for 8020641 (approved [1]) which follows that
for 8014319 (pending [2]).
Thanks,
Brian
[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019017.html
[2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018922.html
