Looks fine Best Lance
-- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone On Jul 25, 2013, at 4:41 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > These changes are already committed in the jsr166 CVS, this is a request to > pull them into jdk8. > > > diff -r fd1b5adcfdf0 > src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java > --- > a/src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java > Wed Jul 24 22:52:01 2013 +0100 > +++ > b/src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java > Thu Jul 25 09:37:25 2013 +0100 > @@ -71,6 +71,7 @@ public abstract class AtomicIntegerField > * > * @param tclass the class of the objects holding the field > * @param fieldName the name of the field to be updated > + * @param <U> the type of instances of tclass > * @return the updater > * @throws IllegalArgumentException if the field is not a > * volatile integer type > diff -r fd1b5adcfdf0 > src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java > --- > a/src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java > Wed Jul 24 22:52:01 2013 +0100 > +++ > b/src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java > Thu Jul 25 09:37:25 2013 +0100 > @@ -71,6 +71,7 @@ public abstract class AtomicLongFieldUpd > * > * @param tclass the class of the objects holding the field > * @param fieldName the name of the field to be updated > + * @param <U> the type of instances of tclass > * @return the updater > * @throws IllegalArgumentException if the field is not a > * volatile long type > diff -r fd1b5adcfdf0 > src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java > --- > a/src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java > Wed Jul 24 22:52:01 2013 +0100 > +++ > b/src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java > Thu Jul 25 09:37:25 2013 +0100 > @@ -91,6 +91,8 @@ public abstract class AtomicReferenceFie > * @param tclass the class of the objects holding the field > * @param vclass the class of the field > * @param fieldName the name of the field to be updated > + * @param <U> the type of instances of tclass > + * @param <W> the type of instances of vclass > * @return the updater > * @throws ClassCastException if the field is of the wrong type > * @throws IllegalArgumentException if the field is not volatile > > -Chris.