On Aug 1, 2013, at 9:38 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 01/08/2013 08:49, Paul Sandoz wrote: >> >> On Aug 1, 2013, at 4:45 PM, Henry Jen <henry....@oracle.com> wrote: >>> In StremSpliterator:366, I assume the NULL check should be before if. >>> >> It saves a redundant check if the wrapping spliterator uses buffering, since >> the tryAdvance will also check: >> > It looks like the explicit check in DoubleWrappingSpliterator. > forEachRemaining is redundant although unlikely to be noticeable. Otherwise > looks fine to me. > Thanks, well spotted, same for LongWrappingSpliterator too, i fixed those to be consistent with the others. Paul.
