Looking at the jdk7 source and comparing your change this looks OK. Would be good to get one more pair of eyes on this as well but I think you should be good to go
Best Lance On Aug 23, 2013, at 10:41 AM, Daniel Fuchs wrote: > Hi, > > Please find below a fix for: > > 8005899: Logger.getLogger(name, null) should not allow to reset > a non-null resource bundle > > The issue here is that whereas in JDK 7, > Logger.getLogger("foo", null); > will throw an IllegalArgumentException if "foo" has a non null > bundle name, JDK 8 will simply ignore the 'null' parameter and > behave as > Logger.getLogger("foo"); > > The fix below restores the IllegalArgumentException in JDK 8. > > <http://cr.openjdk.java.net/~dfuchs/webrev_8005899/webrev.00/> > > best regards, > > -- daniel
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com