On 26/08/2013 21:54, Xueming Shen wrote:
Hi,

Please help review the proposed change for 8023647:

http://cr.openjdk.java.net/~sherman/8023647/webrev

It appears group index updating in situation of GroupCurly backing off
is incorrect from day one (the bug is reproducible back to jdk5). The
current implementation does not back off the index to a previous match,
but the one is being back off.

The ln#4459 is updating a local variable before return, which is not
necessary, I removed it with this change.
This looks okay to me, I just wonder if there we need other tests here to be confident that there aren't other issues.

-Alan

Reply via email to