Thank you, Alan.

I have updated my webrev to http://cr.openjdk.java.net/~dxu/4792059/webrev.01/.

-Dan


On 08/28/2013 04:05 AM, Alan Bateman wrote:
On 28/08/2013 00:20, Dan Xu wrote:
Hi,

When GeneralSolaris testcase follows symbolic link to pick up an existing file or directory for testing, it will fail the assertion in check()method because the file path canonicalization process will result in the real path not a path containing symbolic link. I enforce this test not to use any symbolic link as a testing file ordirectory to avoid this problem. Please help review my fix. Thanks!

bug: https://bugs.openjdk.java.net/browse/JDK-4792059
webrev: http://cr.openjdk.java.net/~dxu/4792059/webrev/

-Dan
You can drop the exists check as Files.isXXXX can't return true if the file doesn't exist. Otherwise looks okay to me.

-Alan.

Reply via email to