On 9/25/13 4:03 PM, Martin Buchholz wrote:
Looks good. I would only suggest the stylistic improvement of using proper /** javadoc comments even for private test methods instead of /*
The comments were meant as internal documentation and not "real" javadoc. After dabbling with some doclint cleanup a while ago, I'm inclined now to only use /** if what I'm writing will be doclint-clean. testItr(), for instance, would (at least) need @param tags and that's more than I thought was needed for this test code.
So that was the thinking there. Thanks, -Brent