The additional change looks fine.

On Oct 15 2013, at 16:14 , David Holmes <[email protected]> wrote:

> An additional fix is needed due to a very recent rename :(
> 
> java/net/HttpURLPermission/URLTest.java renamed to 
> java/net/URLPermission/URLTest.java
> 
> Updated webrev:
> 
> http://cr.openjdk.java.net/~dholmes/8026378/webrev.v2/
> 
> On 16/10/2013 2:19 AM, Mike Duigou wrote:
>> Thanks for this cleanup.
>> 
>> Looks fine to me.
> 
> Thanks for the review.
> 
>> It is disappointing to see some of the tests disabled for compact1 or 
>> compact2 because they use unrelated functionality. Is any effort planned to 
>> eliminate unnecessary dependencies?
> 
> This is up to the test owners. I have heard that the TestNG issue is being 
> looked at.

So the root problem is that TestNG requires XML as it is currently being used?

Mike

> 
> David
> -----
> 
>> Mike
>> 
>> On Oct 14 2013, at 22:02 , David Holmes wrote:
>> 
>>> http://cr.openjdk.java.net/~dholmes/8026378/webrev/
>>> 
>>> Trivial cleanup:
>>> 
>>> Non-existent java/util/SummaryStatistics deleted from group jdk_stream
>>> 
>>> Non-existent com/oracle/security deleted from jdk_security3
>>> 
>>> java/util/jar/Manifest/CreateManifest.java - moved from needs_jdk to 
>>> needs_jre
>>> 
>>> jdk/lambda/separate/Compiler.java - moved from needs_jdk to needs_compact3
>>> 
>>> java/util/Collection/ListDefaults.java renamed to 
>>> java/util/List/ListDefaults.java
>>> 
>>> Thanks,
>>> David
>> 

Reply via email to