On 25/10/2013 16:59, Martin Buchholz wrote:
After rebasing, I propose this change which is shorter and is more obviously correct.

I agree, this is simpler (more obvious) so it is a good clean-up. One additional thing may be to add a comment to explain why processExited is synchronized (or alternatively move the synchronization to drainInputStream where it is required to ensure that other threads don't read anything between available and read).

-Alan

Reply via email to