On 10/30/2013 7:38 AM, Alan Bateman wrote:
On 30/10/2013 02:06, Mandy Chung wrote:
I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/

Mandy
I've looked through the updated webrev and the changes look okay to me (I didn't see anything obviously wrong). It is bit annoying to have to special case javax.crypto, I've often wondered if it really necessary to continue to put these classes in jce.jar.


I also have the same question and plan to follow up. When we have modules in jdk9, this workaround will no longer be needed.

The -showLabel looks useful but I could imagine the output being very cluttered (time will tell).


Yup and will be useful for clean graphs.

The new test classes have 2012 in the header, otherwise looks okay.

Will fix it before the push.

Thanks
Mandy

Reply via email to