Hi Tristan,
Without commenting on the specifics of this test, in my estimation we
should strongly favor rewriting shell tests as Java programs, as has
already largely been done in the langtools area:
"Shelling Tests"
https://blogs.oracle.com/jjg/entry/shelling_tests
-Joe
On 10/31/2013 10:22 PM, Tristan Yan wrote:
Hi Everyone
I am working on bug https://bugs.openjdk.java.net/browse/JDK-7190106. Based on
my research, it looks like the issue of fixed port was already addressed by
Stuart Marks in other RMI tests which are Java based. I would like to reuse his
solution, however it does not work for shell based tests. Given this,
1. Fixing the shell based test to address this bug may not be the best solution
2. My recommendation would be to convert this shell script test into Java based
test and re-use the dynamic port allocation solution by Stuart Marks to address
the issue
3. Also this test was written with server/client mode in shell script. In the past there
have been sync issues between server/client which caused the test to fail. If we convert
the shell script into Java based test, it would avoid using "sleep 10"
mechanism to allow for server and client to start up and also give us better control in
synchronizing server and client.
Please let me know if you have any comments or suggestions.
Thank you
Tristan
