On Nov 4, 2013, at 8:36 PM, Joel Borggrén-Franck <joel.fra...@oracle.com> wrote:

> Hi
> 
> Please review this small refactoring of the type annotations reflection code. 
> This fix just makes the types final since the code wasn't designed for 
> inheritance.
> 
> webrev: http://cr.openjdk.java.net/~jfranck/8027796/webrev.00/
> jbs: https://bugs.openjdk.java.net/browse/JDK-8027796
> 

+1

FWIW (take it or leave it) the "final" on 
AnnotatedTypeFactory.buildAnnotatedType is redundant since AnnotatedTypeFactory 
is final and thus cannot be overridden with another class that shadows the 
static method.

Paul.

Reply via email to