Hi,
Can I ask reviewers to look at this fix? As was mentioned, the testing issues described in request were resolved.

Thanks in advance,
Aleksej

On 11/06/2013 11:11 PM, Aleksej Efimov wrote:
Hi,
We have a fix for JDK-8027848 and it was approved in parallel thread. With '-XX:-UseMathExactIntrinsics' tests run flag and applied fix for JDK-8027848 all tests from the following test sets are passing: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time test/java/util/Formatter. I suppose, that we're good to go with this change, unless there are some comments or issues.

-Aleksej

On 11/05/2013 10:07 PM, Aleksej Efimov wrote:
Alan,
Thank you for advise.
I have executed the same test sets with -XX:-UseMathExactIntrinsics and, as was expected, there is only one failure: sun/util/calendar/zi/TestZoneInfo310.java.

-Aleksej

On 11/05/2013 09:50 PM, Alan Bateman wrote:
On 05/11/2013 16:38, Aleksej Efimov wrote:
Hi,

Can I have a review for tzdata2013h integration [1]. The webrev link can be located here [2].

The following test sets were executed on build with fix:
test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time test/java/util/Formatter

And here is the list of failures:
FAILED: java/time/tck/java/time/temporal/TCKWeekFields.java %1%
FAILED: java/time/tck/java/time/TCKInstant.java %1%
FAILED: java/time/tck/java/time/TCKLocalDate.java %1%
FAILED: java/time/tck/java/time/TCKLocalDateTime.java %1%
FAILED: java/time/tck/java/time/TCKOffsetDateTime.java %1%
FAILED: java/time/tck/java/time/TCKOffsetTime.java %1%
FAILED: java/time/tck/java/time/TCKZonedDateTime.java %1%
FAILED: java/time/test/java/time/format/TestZoneTextPrinterParser.java %1%
FAILED: java/util/Calendar/JavatimeTest.java %1%

FAILED: sun/util/calendar/zi/TestZoneInfo310.java


The group %1% tests failures relates to the JDK-8027622 bug and are expected (actually, it was already resolved in hotspot repo).
In another thread, Amy Lu is updating the ProblemList.txt to exclude these tests until the hotspot fix gets to jdk8/tl. For your testing then you could run with -XX:-UseMathExactIntrinsics and check that the all tests related to time and time zones are passing.

-Alan.



Reply via email to