HI, Volker.
Thanks for clarification. The fix looks good.
On 11/27/13 12:48 AM, Volker Simonis wrote:
Hi Sergey,
on AIX, there's already a typedef for "boolean_t" in sys/types.h
that's why we have to omit it from ecc_impl.h to avoid compile errors.
The question regarding the copyright headers has been already answered
by Iris (thanks Iris).
Thank you and best regards,
Volker
On Tuesday, November 26, 2013, Sergey Bylokhov wrote:
On 26.11.2013 21:03, Alan Bateman wrote:
On 26/11/2013 16:23, Volker Simonis wrote:
Hi,
thanks to everybody for the prompt and helpful reviews.
Here comes the
final webrev which incorporates all the corrections and
suggestions from
the second review round:
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
<http://cr.openjdk.java.net/%7Esimonis/webrevs/8024854.v3/>
I've successfully build (and run some smoke tests) with
these changes on
Linux (x86_32, x86_64, ppc64), Solaris/sparcv9,
Windows/x86_64, MacOSX and
AIX (5.3, 7.1).
I've skimmed over the last webrev with focus on:
NetworkingLibraries.gmk where I see this is now fixed for all
platforms.
net_util.* and the platform specific net_util_md.* where I see
you've added platformInit so it's much cleaner.
I have a question about boolean_t in the [1]. Is it correct to
skip it in the new block?
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/src/share/native/sun/security/ec/impl/ecc_impl.h.frames.html
<http://cr.openjdk.java.net/%7Esimonis/webrevs/8024854.v3/src/share/native/sun/security/ec/impl/ecc_impl.h.frames.html>
Also I have a question about headers in the added files. Looks
like different templates are used:
+ src/solaris/classes/java/lang/UNIXProcess.java.aix
2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates.
All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ src/aix/porting/porting_aix.h
2 * Copyright 2012, 2013 SAP AG. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ src/aix/native/sun/tools/attach/AixVirtualMachine.c
2 * Copyright (c) 2008, 2013, Oracle and/or its affiliates.
All rights reserved.
3 * Copyright 2013 SAP AG. All rights reserved.
4 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
etc..
Do we have some rules about that?
UnixNativeDispatcher.c where the error translation is now
removed (and looks fine).
So overall it looks good to me and should be pushed to the
staging forest once you hear from others that commented
previously.
-Alan
--
Best regards, Sergey.
--
Best regards, Sergey.
