On 12/11/13 2:37 PM, Mandy Chung wrote:
The change looks okay. The error(...) method is called to print warnings seems to be confusing. Perhaps better to call output(getText(....)) directly?
Yeah, it's confusing. I'll change it.
One other note: AFAIK the last message drop for jdk8 localization was done. It means that the Japanese and Chinese version will not be updated matching your patch. It's okay for the new warning message as it will fall back to the default English version. For the existing -v1.1, -vcompat, -v1.2 options, the Japanese and Chinese version will not have "(deprecated)" word in it. I suggest to edit the other localized versions to update the modified existing messages.
Good point. I'll check with the localization folks on this. s'marks
