H Dan, No comments on the logic, but the comment format seemed a bit strange to me (notice the extra '//')
Best Lance On Jan 6, 2014, at 6:07 PM, Dan Xu wrote: > Hi Lance, > > Thanks for your review. > > My understanding towards the for loop in lockFile() of > FileSystemPreferences.java is that it retries if anything fails. So I don't > touch L914 to keep its old logic un-changed. Please let me know if you have > some good suggestions. Thanks! > > -Dan > > > On 01/06/2014 02:35 PM, Lance Andersen - Oracle wrote: >> Dan, >> >> Looks OK, but line 914 which you did not change, notice the comments not >> sure if that is common in this code but seemed a bit off to me: >> >> 914 // // If at first, you don't succeed... >> On Jan 6, 2014, at 5:29 PM, Dan Xu wrote: >> >>> Hi All, >>> >>> Please review the simple fix for JNI pending exceptions in >>> FileSystemPreferences.c. Thanks! >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028726 >>> Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/ >>> >>> -Dan >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >> > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
