On Jan 9, 2014, at 1:48 AM, Paul Sandoz wrote: > This generally looks good, rather clever trick, i prefer it to using a cache. > > I agree with Joe some comments are required as it is not immediately obvious > how this works.
I have some simpler comments almost done being redacted. > The additional tests seem adequate (overflow of the overflow), it's easy to > go overboard e.g. you could test: > > BigInteger b = quotient.multiply(BigInteger.valueOf(radix + N)); > > for some range of N according to the radix under test. However, it might be > useful to accurately test boundary conditions. Working on that also. Thanks, Brian
