Hello,
Please review my proposed changes for:
JDK-8035453: Fix serial lint warnings in com.sun.tools and elsewhere
http://cr.openjdk.java.net/~darcy/8035453.0/webrev/
-Joe
---
old/src/share/classes/com/sun/java/browser/dom/DOMAccessException.java
2014-02-20 13:03:06.000000000 -0800
+++
new/src/share/classes/com/sun/java/browser/dom/DOMAccessException.java
2014-02-20 13:03:06.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2000, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -25,6 +25,7 @@
package com.sun.java.browser.dom;
+@SuppressWarnings("serial") // JDK implementation class
public class DOMAccessException extends Exception
{
/**
---
old/src/share/classes/com/sun/java/browser/dom/DOMUnsupportedException.java
2014-02-20 13:03:06.000000000 -0800
+++
new/src/share/classes/com/sun/java/browser/dom/DOMUnsupportedException.java
2014-02-20 13:03:06.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2000, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -25,7 +25,7 @@
package com.sun.java.browser.dom;
-
+@SuppressWarnings("serial") // JDK implementation class
public class DOMUnsupportedException extends Exception
{
/**
---
old/src/share/classes/com/sun/tools/example/debug/expr/ExpressionParser.java
2014-02-20 13:03:07.000000000 -0800
+++
new/src/share/classes/com/sun/tools/example/debug/expr/ExpressionParser.java
2014-02-20 13:03:07.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -2172,6 +2172,7 @@
throw generateParseException();
}
+ @SuppressWarnings("serial") // JDK implementation class
static private final class LookaheadSuccess extends java.lang.Error { }
final private LookaheadSuccess jj_ls = new LookaheadSuccess();
private boolean jj_scan_token(int kind) {
---
old/src/share/classes/com/sun/tools/hat/internal/oql/OQLException.java
2014-02-20 13:03:07.000000000 -0800
+++
new/src/share/classes/com/sun/tools/hat/internal/oql/OQLException.java
2014-02-20 13:03:07.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2008, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -36,6 +36,7 @@
* OQLException is thrown if OQL execution results in error
*
*/
+@SuppressWarnings("serial") // JDK implementation class
public class OQLException extends Exception {
public OQLException(String msg) {
super(msg);
--- old/src/share/classes/com/sun/tools/jdi/ConnectorImpl.java
2014-02-20 13:03:08.000000000 -0800
+++ new/src/share/classes/com/sun/tools/jdi/ConnectorImpl.java
2014-02-20 13:03:08.000000000 -0800
@@ -144,6 +144,7 @@
return string;
}
+ @SuppressWarnings("serial") // JDK implementation class
abstract class ArgumentImpl implements Connector.Argument,
Cloneable, Serializable {
private String name;
private String label;
---
old/src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java 2014-02-20
13:03:08.000000000 -0800
+++
new/src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java 2014-02-20
13:03:08.000000000 -0800
@@ -351,6 +351,7 @@
}
@Override
+ @SuppressWarnings("serial") // Anonymous class
public AnnotationVisitor visitAnnotationDefault() {
return new AnnotationNode(new ArrayList<Object>(0) {
@Override
---
old/src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java
2014-02-20 13:03:09.000000000 -0800
+++
new/src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java
2014-02-20 13:03:09.000000000 -0800
@@ -66,6 +66,7 @@
* @author Bing Ran
* @author Eric Bruneton
*/
+@SuppressWarnings("serial") // JDK-implementation class
public class AnalyzerException extends Exception {
public final AbstractInsnNode node;
--- old/src/share/classes/sun/jvmstat/monitor/MonitorException.java
2014-02-20 13:03:10.000000000 -0800
+++ new/src/share/classes/sun/jvmstat/monitor/MonitorException.java
2014-02-20 13:03:10.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -32,6 +32,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorException extends Exception {
/**
--- old/src/share/classes/sun/jvmstat/monitor/event/HostEvent.java
2014-02-20 13:03:10.000000000 -0800
+++ new/src/share/classes/sun/jvmstat/monitor/event/HostEvent.java
2014-02-20 13:03:10.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class HostEvent extends EventObject {
/**
---
old/src/share/classes/sun/jvmstat/monitor/event/MonitorStatusChangeEvent.java
2014-02-20 13:03:11.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/monitor/event/MonitorStatusChangeEvent.java
2014-02-20 13:03:11.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -35,6 +35,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorStatusChangeEvent extends VmEvent {
/**
--- old/src/share/classes/sun/jvmstat/monitor/event/VmEvent.java
2014-02-20 13:03:12.000000000 -0800
+++ new/src/share/classes/sun/jvmstat/monitor/event/VmEvent.java
2014-02-20 13:03:12.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class VmEvent extends EventObject {
/**
---
old/src/share/classes/sun/jvmstat/monitor/event/VmStatusChangeEvent.java
2014-02-20 13:03:12.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/monitor/event/VmStatusChangeEvent.java
2014-02-20 13:03:12.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -35,6 +35,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class VmStatusChangeEvent extends HostEvent {
/**
---
old/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorDataException.java
2014-02-20 13:03:13.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorDataException.java
2014-02-20 13:03:13.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorDataException extends MonitorException {
/**
---
old/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorStructureException.java
2014-02-20 13:03:14.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorStructureException.java
2014-02-20 13:03:14.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorStructureException extends MonitorException {
/**
---
old/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorTypeException.java
2014-02-20 13:03:14.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorTypeException.java
2014-02-20 13:03:14.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorTypeException extends MonitorException {
/**
---
old/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorVersionException.java
2014-02-20 13:03:15.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/perfdata/monitor/MonitorVersionException.java
2014-02-20 13:03:15.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -35,6 +35,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class MonitorVersionException extends MonitorException {
/**
---
old/src/share/classes/sun/jvmstat/perfdata/monitor/SyntaxException.java
2014-02-20 13:03:16.000000000 -0800
+++
new/src/share/classes/sun/jvmstat/perfdata/monitor/SyntaxException.java
2014-02-20 13:03:16.000000000 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -36,6 +36,7 @@
* @author Brian Doherty
* @since 1.5
*/
+@SuppressWarnings("serial") // JDK implementation class
public class SyntaxException extends Exception {
int lineno;
