On Mar 5, 2014, at 5:10 PM, huizhe wang wrote: > > On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote: >> On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote: >> >>> nitpicking, >>> >>> (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" >>> as well? >> I would agree given you are now calling Character.toLowerCase > > Also, at line 463 and 464, it looks like 'uppers' meant to be 'lowers' > defined at 462.
I think we should add tests with this change it looks like we really need to test this if your suggestion above is correct. > >>> (2) StringBuilder can be used to replace the StringBuffer in toString(). >> Agree, but I think this could be considered optional for this putback... > > Yes, feel free to replace StringBuffer with StringBuilder, Vector to > ArrayList and etc. > > -Joe > >> >> >>> -Sherman >>> >>> On 03/05/2014 12:18 PM, David Li wrote: >>>> Hi, >>>> >>>> This is an update from Xerces for file impl/xpath/regex/TokenRange.java. >>>> For details, please refer to: >>>> https://bugs.openjdk.java.net/browse/JDK-8035577. >>>> >>>> Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/ >>>> >>>> No new tests. There were none added in Xerces. >>>> >>>> Existing tests: JAXP SQE and unit tests passed. >>>> >>>> Thanks, >>>> David >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >> >
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
