Thanks Paul, for the review!.
Hi,
Eye-balled the changes, nothing obvious popped out. Looks good.
It's very minor, and should not block the code going back, but "occured" is a common
misspelling of "occurred".
fyi, these are *all* changes made upstream, by the ASM team, the only
file we
generate is the version.txt to help us identify what we have.
Kumar
Paul.
On Mar 12, 2014, at 10:24 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com>
wrote:
Hello,
Appreciate if someone cane review this change, so that I can push this into the
jdk9 repository,
refreshing the internal ASM sources from rev 1700 to 1721, of particular
interest is
Rev 1710, which fixes [1] known to cause verification errors in the VM.
Thereafter I will be back-porting this changeset into 8u20.
http://cr.openjdk.java.net/~ksrini/8037221/
The following regression tests have been run:
nashorn/test
jdk/test/tools/pack200
jdk/test/java/lang/invoke
jdk/test/java/util
jdk/test/javax/script
jdk/test/sun/tools/jrunscript
jdk/test/closed/com/oracle/jfr
langtools/test
Nashorn additional test targets:
test
test262
octane
Thanks in advance
Kumar
[1] http://forge.ow2.org/tracker/?group_id=23&atid=100023&func=detail&aid=316545
