On 16/03/2014 16:52, Ivan Gerasimov wrote:
Would you please take a look at the updated webrev with your
suggestions incorporated:
http://cr.openjdk.java.net/~igerasim/6943190/3/webrev/
Ivan - I see that a number of the tests have been changed to /othervm
and I'm wondering what the reason for this is. Clearly tests for Process
will be launching new VMs but it would be great if we could avoid having
to launch a VM for the test "main" too.
Another general comment is that if a command is not found the tests will
now pass and the only way to know that anything has gone wrong is to
look in the .jtr file. I would personally prefer the tests to fail so
that any issues in the environment or special-casing for new ports can
be found quickly.
For the Linux or Solaris-only tests then the tests now output an
information message via System.err, I assume this should be System.out
as it's not really an error or usage message.
On the places to search then I'm wondering about /system/bin. Is that
needed? I assume that if there is a port to an operating system that
uses this location then it will be added as part of the port.
-Alan.
