On Mar 24, 2014, at 1:28 PM, Alan Bateman <alan.bate...@oracle.com> wrote:

> On 24/03/2014 11:44, Paul Sandoz wrote:
>> Hi,
>> 
>> Simple patch to align code with spec for stream/spliterator factory methods 
>> on Arrays and spliterator methods on Spliterators, and make the next release 
>> of the JCK happy:
>> 
>>   
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8037857-spliterator-aioob/webrev/
>> 
>> After 9 it should go back to 8u20.
>> 
> This looks good to me.

Thanks.


> The test looks useful too, a minor comment is that I think it's more common 
> to put the test tags at the top after the copyright header.
> 

I like to ensure the first block comment is collapsed in the IDE (as it is 
usually just the license), but that has the unfortunate effect of including any 
directly following blocks (not sure if i can configure it...). In any case i 
will move it up.

Paul.

Reply via email to