Hi Lance,
- The empty method for @BeforeClass, @AfterClass, @BeforeMethod,
@AfterMethod
could be deleted (and related imports)
- Ditto the empty public constructors
- The javadoc first sentences should end with a "." (Though we rarely
generate javadoc for tests).
- Binary files (BatchUpdateException_JDBC42.ser) are rarely a good idea.
Typically the bytes are dumped to a source byte array and embedded
in the test.
- Some tests (like BatchUpdateException) would be easier to read if
there was method for 'equals(ex1, ex2)'.
- Only BatchUpdateException has a serialization test for compatibility
with previous versions.
(the round trip write/read tests only test the current version).
- StubDriverDA logs an error to the Logger instead of causing a test
failure - is that correct?
- BatchUpdateExceptionTests + 320 check indentation
- DriverManagerTests + 291 "to to" -> "to"
- StubConnection +44 add a space before "{"
Roger
On 04/16/2014 05:41 PM, Lance Andersen wrote:
Hi,
Looking for a reviewer for some new java.sql tests.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8040760/webrev.00/
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
