On 05/20/2014 11:07 AM, Miroslav Kos wrote:
Hi Chris,
thanks for pointing - I forgot to add copyright. Will fix.
Thanks.
Regarding jar attachment - this is a slightly modified version of test
as received from customer. If there is any mechanism allowing to use
maven artifact (I am not aware of it) with jprt, it would be definitelly
better solution, but I didn't find it.
I could rewrite the test that it would test just not adding this
handler, but it wouldn't explain much what the issue was about - I could
write it to javadoc?
Let me know, what you think.
I see we have many other jar files under jdk/test, so maybe this is ok.
-Chris.
Thanks
Miran
On 19/05/14 19:27, Chris Hegarty wrote:
Miran,
The source change looks ok to me. Have you commented out the line
adding the handler because it may be reinstated, or as a reminder that
it was deliberately omitted?
The test, at the very minimum, will need a suitable copyright header.
I also wonder if there is any other way of testing this issue without
adding, what appears to be, a large jar file.
-Chris.
On 19/05/14 14:36, Miroslav Kos wrote:
Hi,
this is review request for:
8043129: JAF initialisation in SAAJ clashing with the one in javax.mail
JBS: https://bugs.openjdk.java.net/browse/JDK-8043129
WEBREV:
http://cr.openjdk.java.net/~mkos/8043129/jaxws.00/
http://cr.openjdk.java.net/~mkos/8043129/jdk.00/ (test)
This solves conflict between JAF handlers for JAX-WS and javax.mail. The
issue has been introduced in the latest CPU.
Thanks
Miran
