On 20/06/2014 09:42, Patrick Zhang wrote:
Hi Team,
8035490 is one task used to track xml code colocation from sqe repo
into jaxp repo.
As one initial change set, it includes below materials:
1. TEST.ROOT to declare test code location.
2. ProblemList.txt to exclude 6 tests which have been discussed on past.
3. One Makefile to support future jprt/aurora execution.
4. test code located in bugxxx dir. All are based on testNG.
webrev:
http://cr.openjdk.java.net/~pzhang/xml_colocation/8035490/webrev/
:
(Moving this thread this to core-libs-dev).
At a high-level then it's good to have the tests for JAXP in the same
repository as the code. I've only skimmed over these webrev (not a
review) and they look like they are mostly regression tests for specific
bugs - is that right?
One thing that concerns me a bit is that none of the .java files that I
looked at have any comments to say what the test does. Is there anything
that could be brought over from the original issue in JIRA to explain
what each of these tests is about?
Is Hello.wsdl.data a binary file? Have any alternatives been looked at?
As you mention ProblemList.txt then I see that it has headings that
don't make sense in the jaxp repository, maybe they should be removed.
The webrev only has the changes for jaxp repository, will there be
follow-on changes to make it runnable at the top level, JPRT
configuration, etc.
-Alan
