On 7/9/2014 4:13 AM, Miroslav Kos wrote:
Hi Joe,
thanks for comments - see inline:
On 08/07/14 01:02, huizhe wang wrote:
Hi Miran,
In class
src/share/jaxws_classes/com/sun/tools/internal/xjc/Options.java:
+ // hack to force initialization so catalog manager
system properties take effect
+ staticManager.getVerbosity();
According to Iaroslav (JAXB lead), the initilization is necessary. It
looks like system property is used only if initialization performed
via getter.
Initialization is performed when a CatalogResolver is constructed, where
initializeCatalogs is called that in turn calls
CatalogManager.getCatalog, here's what's on the stack:
CatalogManager.readProperties <-- read properties in
CatalogManager.properties
CatalogManager.queryUseStaticCatalog
CatalogManager.getUseStaticCatalog
CatalogManager.getCatalog
CatalogManager.initalizeCatalogs
CatalogManager.<init>
It doesn't hurt to call the getter since CatalogManager.properties will
be read once, but it doesn't seem necessary to me. The reason I asked
was that if CatalogResolver had not been initialized properly, there
would be a problem with the Catalog impl that we could file a bug and
get it fixed.
Is that necessary? I thought the next call to getCatalog would
initialize the properties from the CatalogManager property file.
Using ServiceLoader in class
src/share/jaxws_classes/javax/xml/ws/spi/Provider.java:
Would you need to give the process privilege? Or maybe the method is
already called in a privileged block?
I think it doesn't - the previous version was exactly same, the only
difference was that it was called via reflection.
It's a use pattern that we use in other places so that when Security
Manager is present, ServiceLoader works as expected.
-Joe
M.
Thanks,
Joe
On 6/30/2014 9:22 AM, Miroslav Kos wrote:
Hi,
there is a bulk update of JAX-B/WS from upstream projects -
webrev: http://cr.openjdk.java.net/~mkos/8044656/jaxws.00/
more details in issue desc:
https://bugs.openjdk.java.net/browse/JDK-8044656
Could I ask for a review/approval?
Thanks
Miran
