+1 On Jul 11, 2014, at 9:11 PM, Stuart Marks <stuart.ma...@oracle.com> wrote:
> Hi all, > > Please review this small patch to fix one of the old RMI tests that has > started failing. This simply removes a couple test cases that use the > (hidden, unsupported) -Xnew option of rmic, which relies on support for old > -source and -target values that were recently removed from javac by the fix > for JDK-8011044. > > For a full explanation, see my comments in the bug report: > > https://bugs.openjdk.java.net/browse/JDK-8050105 > > Thanks, > > s'marks > > > > > # HG changeset patch > # User smarks > # Date 1405126872 25200 > # Fri Jul 11 18:01:12 2014 -0700 > # Node ID 5a8d01866745c116cfe6d676cb1b52b5d46bc96f > # Parent 9d1e46cc39727fc19d9fea9217e20edfcd7289a1 > 8050105: test sun/rmi/rmic/minimizeWrapperInstances/run.sh fails > Reviewed-by: XXX > > diff -r 9d1e46cc3972 -r 5a8d01866745 > test/sun/rmi/rmic/minimizeWrapperInstances/run.sh > --- a/test/sun/rmi/rmic/minimizeWrapperInstances/run.sh Fri Jul 11 > 14:06:42 2014 -0700 > +++ b/test/sun/rmi/rmic/minimizeWrapperInstances/run.sh Fri Jul 11 > 18:01:12 2014 -0700 > @@ -45,9 +45,3 @@ > > ${TESTJAVA}/bin/rmic -classpath ${TESTCLASSES:-.} -d ${TESTCLASSES:-.} > -vcompat PImpl > ${TESTJAVA}/bin/java ${TESTVMOPTS} -classpath ${TESTCLASSES:-.} Test > - > -${TESTJAVA}/bin/rmic -Xnew -classpath ${TESTCLASSES:-.} -d ${TESTCLASSES:-.} > PImpl > -${TESTJAVA}/bin/java ${TESTVMOPTS} -classpath ${TESTCLASSES:-.} Test > - > -${TESTJAVA}/bin/rmic -Xnew -classpath ${TESTCLASSES:-.} -d ${TESTCLASSES:-.} > -vcompat PImpl > -${TESTJAVA}/bin/java ${TESTVMOPTS} -classpath ${TESTCLASSES:-.} Test > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com