Looks good. Ship it! thank you so much Ioi, Jiangli, Calvin, Yumin and David for all the hard work! Karen
On Aug 13, 2014, at 2:25 AM, Ioi Lam wrote: > Hi, > > Thank you all for the reviews! I have prepared a final version that has > incorporated all the comments. > > http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-vfinal/ > > - Ioi > > On 8/9/14, 1:02 AM, Ioi Lam wrote: >> Hi, >> >> Thanks a lot to everyone for the very useful comments. I have updated the >> webrev >> >> Just the delta from the previous round of review: >> >> http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v3_delta_from_v2/ >> >> All the changes: >> >> http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v3/ >> >> Thanks >> - Ioi >> >> On 7/28/14, 4:09 PM, Ioi Lam wrote: >>> Hi Folks, >>> >>> Please review the following clean up and refactoring of the CDS code, for >>> JDK9 >>> >>> http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v2/ >>> https://bugs.openjdk.java.net/browse/JDK-8046070 >>> >>> Summary of fix: >>> >>> Clean up and refactor the Class Data Sharing (CDS) code, including: >>> >>> + Improve archive integrity checking >>> + Support bytecode verification during archive dumping time >>> + Allow the user to configure the CDS class list and archive file. >>> + Allow future extension of the CDS class loading mechanism. >>> >>> Tests: >>> >>> JPRT >>> UTE (vm.runtime.testlist, vm.quick.testlist, >>> vm.parallel_class_loading.testlist) >>> Various adhoc SQE tests on Aurora >>> JCK >>> >>> Thanks >>> - Ioi >> >
