Hi Tristan,

Nice work! As with those converted by Eric (8051561), the new tests looked much better and cleaner than the original ones.

I see that you're using jaxp.library instead of a base class as in Eric's previous webrev. Is this the final decision on the whole test structure? It looks good.

Have you run them with and without security manager?

Thanks,
Joe

On 8/18/2014 10:46 AM, Tristan Yan wrote:
Hi Joe, Alan and others
We’re working on moving our internal jaxp functional tests to open idk repo(Include refactoring effort). This is the first open review I am asking for SAX and Transform. Would you please review these tests. Any comment will be appreciated.

I put the webrev as follows:
http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev00/ <http://cr.openjdk.java.net/%7Etyan/JDK-8051540/webrev00/>

Thank you very much.
Tristan

Reply via email to