Re: Replace concat String to append in StringBuilder parameters

[Andrej Golovnin]

Hi all,

src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java:
269                 .append(LINE_SEP + "g:" + LINE_SEP)

should be changed to:
269                 .append(LINE_SEP).append( "g:").append(LINE_SEP)


src/java.base/share/classes/sun/security/x509/PolicyInformation.java:
 260     public String toString() {
 261         StringBuilder sb = new StringBuilder("  [" +
policyIdentifier.toString());
 262         sb.append(policyQualifiers).append("  ]\n");
 263         return sb.toString();
 264     }

should be changed either to:
 260     public String toString() {
 261         StringBuilder sb = new StringBuilder("  [");
 262         sb.append(policyIdentifier);
 263         sb.append(policyQualifiers).append("  ]\n");
 264         return sb.toString();
 265     }

or to:
 260     public String toString() {
 261         return "  [" + policyIdentifier + policyQualifiers + "  ]\n";
 262     }


src/java.base/share/classes/sun/security/x509/X509CRLEntryImpl.java:
 316                             sb.append("Extension unknown: " + "DER
encoded OCTET string =\n")

should be changed to:
 316                             sb.append("Extension unknown: DER encoded
OCTET string =\n")

same problems are in
src/java.base/share/classes/sun/security/x509/X509CRLImpl.java in the line
576
src/java.base/share/classes/sun/security/x509/X509CertInfo.java in the line
332

Best regards,
Andrej Golovnin