> On 29 Aug 2014, at 16:56, Martin Buchholz <marti...@google.com> wrote: > > Looks fine.
+1 -Chris. > Instead of using Contributed-by: for Doug's work, you should make him the > hg "user", as is done in previous changesets. E.g. hg import has a --user > flag. > > All of jsr166 CVS src/main is ready for sync'ing with openjdk9, i.e. there > are no known bugs, even though some future improvements are on the TODO > list. > > >> On Fri, Aug 29, 2014 at 3:01 AM, Paul Sandoz <paul.san...@oracle.com> wrote: >> >> Hi, >> >> Please review fixes by Doug to j.u.c.CompletableFuture to better control >> resources for long completion chains (e.g. avoiding stack overflows). This >> fix resulted in a lot of internal refactoring and clean up. There are also >> some doc clarifications for certain j.u.c.CompletationStage exception >> handling methods (which most likely means a CCC is required). >> >> https://bugs.openjdk.java.net/browse/JDK-8056249 >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8056249-cf-resource-usage/webrev/ >> >> >> -- >> >> Is the following snippet missing from the doc updates to the methods >> CompletationStage.handle and handleAsync? >> >> If the supplied function itself encounters an >> exception, then the returned stage exceptionally completes with this >> exception unless this stage also completed exceptionally. >> >> Paul. >>
