On Sep 5, 2014, at 2:30 PM, Remi Forax <fo...@univ-mlv.fr> wrote: > > On 09/05/2014 12:31 PM, Paul Sandoz wrote: >> On Sep 5, 2014, at 10:09 AM, Vladimir Ivanov <vladimir.x.iva...@oracle.com> >> wrote: >> >>> http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057654 >>> >> +1 >> >> Paul. > > *@SuppressWarnings("LocalVariableHidesMemberVariable")* > > AFAIK, this is not a standard suppress warnings name, > i would prefer not having this kind of annotation in the code because IMO, it > doesn't pull it's own weight. >
I nearly called that out too (sitting on the fence a little in this respect). Might be worth doing as a separate pass. Paul.
