Hi Lance, I probably don't know enough about rowset to qualify as reviewer for this change, but I had a look at the tests - and I believe they look good. I wonder whether there should be some additional tests that would run with a security manager on?
The only thing unusual I noticed is that the jars seem to have a .DS_Store in their META-INF ;-) best regards, -- daniel On 01/10/14 19:55, Lance Andersen wrote:
Hi all, Looking for a reviewer for the unit tests being added for RowSetFactory and RowSetProvider. The webrev can be found at http://cr.openjdk.java.net/~lancea/8059570/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com