Looks fine Daniel Best Lance
-- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] Sent from my iPhone > On Oct 7, 2014, at 7:24 AM, Daniel Fuchs <[email protected]> wrote: > >> On 07/10/14 13:22, Lance Andersen wrote: >> Hi Daniel, >> >> Couldn't you just do >> >> x.append(' ').append('{').append(i).append('}'); >> >> and avoid the String.valueOf() or do you find the performance the same? > > Hi Lance, > > I refreshed the webrev to remove the String.valueOf() > > best regards, > > -- daniel > >> >> Best >> Lance >>> On 7 Oct 2014, at 11:59, Daniel Fuchs <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>>> Hi, >>>> >>>> Please find below a trivial fix for >>>> >>>> 8028788: Logger.enterring uses String concatenation in a loop >>>> https://bugs.openjdk.java.net/browse/JDK-8028788 >>>> >>>> webrev: >>>> http://cr.openjdk.java.net/~dfuchs/webrev_8028788/webrev.00 >>>> >>>> best regards >>>> >>>> -- daniel >> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >> Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> [email protected] <mailto:[email protected]> >
