Hi Martin,
You're welcome in the jaxp land :-) Bandaid is what we need for now.
There are many things we would like to do to this aging code base,
unfortunately, we have to focus on a few.
The change looks okay. I did a full-test run and saw no failures.
One thing to note is that the SQE team has been working on migrating
jaxp unit and functional tests into the jaxp repo. Before that's done,
we should continue putting unit tests in jdk/test. I've moved your test
to jdk/test and also removed a few unused imports.
http://cr.openjdk.java.net/~joehw/jdk9/7156085/webrev/
I saw that you included a license header in the test that had a
structure like: Google copyright + GNU GPL. I saw that you've already
done it before (e.g. JDK-8058520). I don't have a problem with the lic
header itself. But I'd like to know that the License Structure was
approved by legal. Has it been approved?
Thanks,
Joe
On 10/28/2014 3:49 PM, Martin Buchholz wrote:
Hi Joe,
I'd like you to do a code review.
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/xerces-UTF8Reader-supplementary-characters/
https://bugs.openjdk.java.net/browse/JDK-7156085#comment-13569882
https://issues.apache.org/jira/browse/XERCESJ-1257
As usual, I don't know what I'm doing in jaxp land.
This bug should be fixed in both upstream xerces and in openjdk's copy.
Probably the xerces private UTF8 decoder should be thrown out, but I'm
only trying to bandaid the code here.
