Hi Joe Thanks for your comments!
I have corrected the typo error in ProblemList.txt. The Unexpected Error happened on the file beginning with BOM, the corresponding tests are to test BOM utf file. Because there is no mistake in the code, so I would not modify them for webrev tool, after all the reviewer can check the raw file. To Tristan Would you like to move the webrev and the test result to cr.openjdk.java.net for me? http://sqeweb.us.oracle.com/jsn/users/yc/webrev.zip http://sqeweb.us.oracle.com/jsn/users/yc/result.zip Best Regards Frank -----Original Message----- From: huizhe wang [mailto:[email protected]] Sent: Thursday, November 06, 2014 3:28 AM To: Frank Yuan Cc: 'Core-Libs-Dev'; 'jibing chen'; 'Gustavo Galimberti'; [email protected] Subject: Re: Review request for XML JAXP unit test colocation Hi Frank, It's great to see that you re-categorized the tests and consolidated them into their proper categories. The webrev still shows Unexpected Error when creating diff for binary files, e.g. Hello.wsdl, an issue with how Mercurial handles them (never had problem with subversion before). I suggest removing these wsdl files, and creating the xml within the tests themselves as literal strings, for example for Bug6388460, replace the 'source' with the content of Hello.wsdl (Note NetBeans can do this automatically: type double quote and then paste the content of Hello.wsdl): Source source = new StreamSource(new StringReader( "<?xml version=\"1.0\" encoding=\"UTF-16\"?>\n" + "<wsdl:definitions xmlns:soap=\"http://schemas.xmlsoap.org/wsdl/soap/\"\n"; + " xmlns:tns=\"http://www.example.org/Hello/\"\n"; + " xmlns:wsdl=\"http://schemas.xmlsoap.org/wsdl/\"\n"; + " xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\"; name=\"Hello\"\n" + " targetNamespace=\"http://www.example.org/Hello/\";>\n" + " \n" + " <wsdl:message name=\"SayHelloResponse\">\n" + " <wsdl:part name=\"SayHelloResponse\" type=\"xsd:string\" />\n" + " </wsdl:message>\n" + " <wsdl:message name=\"SayHelloRequest\">\n" + " <wsdl:part name=\"SayHelloRequest\" type=\"xsd:string\" />\n" + " </wsdl:message>\n" + " <wsdl:portType name=\"Hello\">\n" + " <wsdl:operation name=\"SayHello\">\n" + " <wsdl:input message=\"tns:SayHelloRequest\" />\n" + " <wsdl:output message=\"tns:SayHelloResponse\" />\n" + " </wsdl:operation>\n" + " </wsdl:portType>\n" + " \n" + " <wsdl:binding name=\"HelloSOAP\" type=\"tns:Hello\">\n" + " <soap:binding style=\"rpc\"\n" + " transport=\"http://schemas.xmlsoap.org/soap/http\"; />\n" + " <wsdl:operation name=\"SayHello\">\n" + " <soap:operation\n" + " soapAction=\"http://www.example.org/Hello/SayHello\"; />\n" + " <wsdl:input>\n" + " <soap:body namespace=\"http://www.example.org/Hello/\"\n"; + " parts=\"SayHelloRequest\" use=\"literal\" />\n" + " </wsdl:input>\n" + " <wsdl:output>\n" + " <soap:body namespace=\"http://www.example.org/Hello/\"\n"; + " parts=\"SayHelloResponse\" use=\"literal\" />\n" + " </wsdl:output>\n" + " </wsdl:operation>\n" + " </wsdl:binding>\n" + " <wsdl:service name=\"Hello\">\n" + " <wsdl:port binding=\"tns:HelloSOAP\" name=\"HelloSOAP\">\n" + " <soap:address location=\"http://www.example.org/\"; />\n" + " </wsdl:port>\n" + " </wsdl:service>\n" + "</wsdl:definitions>\n" )); Just spotted a minor typo in ProblemList.txt: exclued -> excluded Thanks, Joe On 11/5/2014 1:12 AM, Frank Yuan wrote: > Hi, Joe and All > > Thanks for your previous reviews and comments. Per your comments: I added > description for every test, got them running with and without security > manager and fixed the known test issues. Could you help review the changes > for JAXP unittest co-location again? After your review, I will push > the tests into JDK repo: jaxp/test. > > bug: https://bugs.openjdk.java.net/browse/JDK-8043090 > webrev: http://sqeweb.us.oracle.com/jsn/users/yc/webrev/ > test results: > http://sqeweb.us.oracle.com/jsn/users/yc/result/JTreport/html/index.ht > ml > > Thanks, > > Frank >
