Hi Martin, I dont know if you saw https://bugs.openjdk.java.net/browse/JDK-8064517 (a followup to your fix for final fields). It would be best to merge those fixes, what do you think?
Otherwise I think that making all lazily initialized fields volatile is not necessary. Since you have made the Type implementations unsafe-publication-tolerable (by making their fields final), the only fields that need to be volatile are those that are used to lazily publish arrays. Am I right? Regards, Peter On Nov 14, 2014 1:03 AM, "Martin Buchholz" <marti...@google.com> wrote: > Hi Joel, Joe, Paul, > > I'd like you to do a code review. > > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/core-reflection-volatile/ > https://bugs.openjdk.java.net/browse/JDK-8064846 >
