Thank you Alan. Yes, the spec is silent on thread safety. Once I finish with adding tests, I will look to update the javadocs to clarify this.
Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 29, 2014, at 5:12 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > >> On 28/11/2014 18:01, Lance Andersen wrote: >> Hi all, >> >> Attached is a trivial change to address the default value for escape >> processing for BaseRowSet. This aligns with the javadocs now for BaseRowSet >> as well as the default for escape process per the JDBC spec and other >> RowSets. >> >> > The javadoc/spec is clear that escape processing is enabled by default so I > think this change is okay (I'm ignoring the issue that it's not volatile and > there's no synchronization, the assumption being that it is not documented as > being thread safe). > > -Alan.