On 12/2/2014 1:47 PM, Lance Andersen wrote:
The revised webrev is here http://cr.openjdk.java.net/~lancea/8060068/webrev.03/ <http://cr.openjdk.java.net/%7Elancea/8060068/webrev.03/>
Looks good. Nit: line 443 and a few places in the getConnection need a space in "for(", "if("
Note, I also tweaked the doPriviliged block for the JDBC property
It's nice to see use of limited doPrivileged. Limited doPrivileged restricts the permissions be accessed by the doPrivileged block. On the other hand, since it only calls System.getProperty, that won't leak any privileges to untrusted code. I think we would need some guideline what can benefit from limited doPrivileged. Anyway, I'm fine with your change.
Mandy
