On 16 Dec 2014, at 11:35, Pavel Rappo <pavel.ra...@oracle.com> wrote:
> The latest webrev summing up all what we've talked so far: > > http://cr.openjdk.java.net/~prappo/8066867/webrev.02/ This looks good to me. Reviewed. Just a note on the attribution. I think it should include at least the following: Contributed-by: Alan Bateman <alan.bate...@oracle.com>, Chris Hegarty <chris.hega...@oracle.com>, Patrick Reinhart <patr...@reini.net>, Pavel Rappo <pavel.ra...@oracle.com> Now this is complete ( modulo any additional review comments ), I think we can move on to Readable.transferTo, and other such goodies. I think we should follow the same model, focus on a single new API, or small logical group, and try to discuss/review/debate it on it’s own merit. Note: I filed https://bugs.openjdk.java.net/browse/JDK-8067661 to track adding more efficient transferTo implementations to other input streams. -Chris. > -Pavel > >> On 15 Dec 2014, at 21:39, Patrick Reinhart <patr...@reini.net> wrote: >> >> >> Have there been any further review being done jet? >> >>> Good catch, guys! >>> >>>> ...the method names are inconsistent (the methods in lower case with >>>> embedded underscores) >>> >>> Fixed. Updated webrev: http://cr.openjdk.java.net/~prappo/8066867/webrev.01/ >> >> -Patrick >
