D'oh, I see it now. Reviewed.
When I first looked at the webrev I couldn't see the chages as the sdiff
was off the screen! Anyway, user error.
-Chris.
On 17/12/14 10:42, Mark Sheppard wrote:
Hi Chris,
thanks for the reply. The bug refers to TestCorbaBug.sh, but I added
the same change to 7056731.sh as a "pre-emptive measure".
If the first is failing then the second will also (at some point). I
looked through the various shell script tests, while some use TESTJAVA,
the majority are using COMPILEJAVA
as the env variable with the path to the jdk tools. So while making the
first change, I thought it convenient to make the second change as well.
I can remove it in this case, if it is thought to be unnecessary at this
juncture.
regards
Mark
On 17/12/2014 09:01, Chris Hegarty wrote:
Mark,
The changes in *test/com/sun/corba/5036554/TestCorbaBug.sh*look fine
to me. I don’t understand the reason for the ones in
*test/com/sun/corba/cachedSocket/7056731.sh.*
-Chris.
On 17 Dec 2014, at 00:48, Mark Sheppard <[email protected]
<mailto:[email protected]>> wrote:
Hi
please oblige and review the follow changes
http://cr.openjdk.java.net/~msheppar/8067151/webrev/
<http://cr.openjdk.java.net/%7Emsheppar/8067151/webrev/>
to address the issue
https://bugs.openjdk.java.net/browse/JDK-8067151
which sees a test failure for JRE only in an embedded environment.
the test scripts now use the env variable COMPILEJAVA rather than
TESTJAVA
regards
Mark
