Looks ok to me Brian. Does the test really verify this? Or just exercise the code?
-Chris > On 23 Dec 2014, at 18:32, Brian Burkhalter <[email protected]> > wrote: > > Please review at your convenience. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8067964 > Patch: http://cr.openjdk.java.net/~bpb/8067964/webrev.00/ > > Summary: > > Use try-with-resources statements to manage AutoCloseables in > sun.tools.native2ascii.Main.convert(). Also clean up code formatting of the > method and remove unneeded import statements. > > Thanks, > > Brian
