On Jan 8, 2015, at 5:06 PM, Chris Hegarty <[email protected]> wrote:
> On 8 Jan 2015, at 15:46, Paul Sandoz <[email protected]> wrote: > >> >> On Jan 8, 2015, at 3:24 PM, Chris Hegarty <[email protected]> wrote: >> >>> This is a review request for a small spec clarification to >>> java.util.stream.Collectors, that appears to be a minor oversight in the >>> original spec. >>> >>> Many of the Collectors that accumulate, group, etc, elements into a >>> Collection, and do not accept a Collection supplier, come with a caveat on >>> the Collection they create, along the lines of, "There are no guarantees on >>> the type, mutability, serializability, or thread-safety of the ... >>> returned". >>> >>> This caveat should be applied to all Collectors that create such >>> Collections. >>> >>> Specdiff: >>> http://cr.openjdk.java.net/~chegar/8068599/specdiff/java/util/stream/Collectors.html >>> webrev: >>> http://cr.openjdk.java.net/~chegar/8068599/webrev/ >>> >> >> Thanks for doing this. The toMap docs are missing 'thread-safety", otherwise >> looks good. > > Fixed. Webrev and specdiff have been updated in place. > +1 Paul.
