Hi Martin,
Excellent, command line parsing of non-ascii has been a issuefor a while.
Is the patch small enough to include in email?
Sorry, but links to non-OpenJDK servers are not covered by the OpenJDK
agreements.
And the openjdk mailer strips off attachments as a defense mechanism.
Is there a Jira issue for this improvement? Do you have a
bugs.openjdk.java.net login?
Having an issue to attach the webrev to would clear up the technical issues
Thanks, Roger
On 1/27/2015 12:21 PM, Martin Sawicki (MS OPEN TECH) wrote:
Hello,
We're proposing an improvement to the OpenJDK intended to fix the currently
existing problem with handling Unicode parameters on the command line in
Windows (via cmd.exe), which prevents users for example in China from properly
passing text strings in their own language via the java.exe command line.
We have a code submission figured out and tested internally. I've uploaded our
webrev package here:
https://openjdkcontrib.blob.core.windows.net/unicodecmd/webrev-20150114.zip
The crux of the change lies in using the "W" (wide character) version of the Windows APIs
for fetching the command line parameters, rather than the "A" (ascii) version. But this
code path is taken only when the following options are set:
-Dwindows.UnicodeConsole=true - switches on Unicode support in the Windows
console
-Dfile.encoding.unicode="UTF-8" - identifies Unicode charset to use; If not
specified, UTF-8 is used by default. Ignored when windows.UnicodeConsole is not set to
true.
We'd appreciate a review and acceptance of this improvement.
And, as this is our first contribution to this sub-project within the OpenJDK,
I apologize for any steps in the submission process that I may have missed here
and would appreciate guidance as needed.
Best regards
Martin Sawicki (and Kirk Shoop, and Valeriy Kopylov)
Microsoft Open Technologies, Inc.
A subsidiary of Microsoft Corp.
