> On 17 feb 2015, at 02:16, John Rose <john.r.r...@oracle.com> wrote: > > On Feb 16, 2015, at 6:25 AM, Staffan Larsen <staffan.lar...@oracle.com > <mailto:staffan.lar...@oracle.com>> wrote: >> >> new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ >> <http://cr.openjdk.java.net/~sla/8025636/webrev.02/> > Looks good; ship it.
Thanks. > > To me this fix raises more questions: > > 1. Are there other places where we generate ACC_SYNTHETIC that should also > get @Hidden annotations? > > 2. Should the JVM be filtering stack frames for ACC_SYNTHETIC (or ACC_BRIDGE > or ACC_MANDATED) calls? (By default? Or perhaps as a new option?) The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The drawback was that the actual lambda method are marked ACC_SYNTHETIC, so that filtered too much. /Staffan > > 3. When will we have a reasonable stack walking mechanism where we can > program such policies in JDK library code, instead of hacking the JVM? > > — John > > P.S. https://bugs.openjdk.java.net/browse/JDK-8043814 > <https://bugs.openjdk.java.net/browse/JDK-8043814>
