I think the fix looks good. I haven't had time to look through the tests in detail (as there are lots) Stephen
On 4 March 2015 at 19:48, Xueming Shen <xueming.s...@oracle.com> wrote: > Stephen and Roger, > > This is the DTF.appendZoneOrOffsetId() issues we discussed last year. > Somehow the > ball was dropped somewhere :-) > > Here is the proposed change we discussed. The only difference is I leave the > ZoneOffset > to throw the DateTimeException, instead of inside the Parsed.query() > directly. > > I also updated the TCKZoneIdPrinterParser to (1) add the > appendZoneOrOffsetId() (it appears > we don't have any corresponding test cases for it) and (2) return a > ZoneOffset for "offset" > if there is indeed a ZoneOffset inside the parsed. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8074406 > webrev: http://cr.openjdk.java.net/~sherman/8074406/webrev > > Thanks! > -Sherman
