Hi Joe,

Looks fine.

Roger


On 3/10/2015 2:12 PM, joe darcy wrote:
Hello,

Recently I sent out a review for

JDK-8074714 : Add javax/xml/jaxp/testng/validation to othervm.dirs in TEST.ROOT http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032151.html

However, I actually added the directory in question to the exclusiveAccess.dirs property rather than the othervm.dirs property. (Doh!)

Please review the patch below to remove javax/xml/jaxp/testng/validation from exclusiveAccess.dirs and put it on othervm.dirs, as originally intended.

Thanks,

-Joe

--- old/test/TEST.ROOT    2015-03-10 11:07:18.027225609 -0700
+++ new/test/TEST.ROOT    2015-03-10 11:07:17.843225610 -0700
@@ -5,10 +5,10 @@
 keys=2d dnd i18n

 # Tests that must run in othervm mode
-othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d sun/pisce
s
+othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d sun/pisce
s javax/xml/jaxp/testng/validation

 # Tests that cannot run concurrently
-exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream javax/xml/jaxp/t
estng/validation
+exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream

 # Group definitions
 groups=TEST.groups [closed/TEST.groups]


Reply via email to