I was only suggesting using final in the stylized final Type foo = this.foo;
Using final for other local variables is going further than most jdk maintainers (including myself) go. OTOH, if you touch code that uses the denigrated char foo[] please change it to char[] foo This is yet another of those global changes to the entire jdk sources that nobody ever gets around to. On Fri, Mar 27, 2015 at 2:51 PM, Lev Priima <lev.pri...@oracle.com> wrote: > Updated and put some more final in other(not @Deprecated) methods: > http://cr.openjdk.java.net/~lpriima/8071571/2/ > > Lev > > On 03/27/2015 11:50 PM, Martin Buchholz wrote: > > > > On Fri, Mar 27, 2015 at 1:49 PM, Lev Priima <lev.pri...@oracle.com> wrote: > >> Martin, >> >> You mean it should be like this: >> char[] val = value; /* avoid getfield opcode */ >> int end = val.length; >> ? >> >> > Yes. > > (although I personally like to write it like this: > > final char[] value = this.value; > int end = value.length; > > > >