Looks good. Would you please also check the number of distinct LFs compiled when running standard benchmarks? (With and without the change.) The number should go up, but only slightly.
Thanks! — John On Apr 9, 2015, at 11:44 AM, Vladimir Ivanov <vladimir.x.iva...@oracle.com> wrote: > > http://cr.openjdk.java.net/~vlivanov/8077054/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8077054 > > It's a followup fix for JDK-8069591 [1]. > > As Charlie observed, it's important to customize DirectMethodHandles as well. > Otherwise, additional frame for DMH LambdaForm is created and it causes > observable peak performance regression in some situations (e.g. JRuby9K). > > Testing: manual (microbenchmark, compilation log inspection). > > Thanks! > > Best regards, > Vladimir Ivanov > > [1] https://bugs.openjdk.java.net/browse/JDK-8069591 > "Customize LambdaForms which are invoked using > MH.invoke/invokeExact" > _______________________________________________ > mlvm-dev mailing list > mlvm-...@openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
